fix(iot): the mount type of hostpath for localtime in napa #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2110 +/- ##
==========================================
+ Coverage 56.09% 56.36% +0.26%
==========================================
Files 186 188 +2
Lines 18092 18341 +249
==========================================
+ Hits 10149 10337 +188
- Misses 6910 6950 +40
- Partials 1033 1054 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YTGhost
approved these changes
Aug 3, 2024
LavenderQAQ
added a commit
to LavenderQAQ/openyurt
that referenced
this pull request
Aug 3, 2024
…o#2110) Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
YTGhost
pushed a commit
that referenced
this pull request
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/sig iot
What this PR does / why we need it:
In the napa version, the host's
/etc/localtimefile is mounted as a file, whereas previously the default bind type foropenyurt/auto-collectorwas a folder. This pr is fixed to file.This may have caused pr #2103 to fail iot e2e.