Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace markdown misspell with typos check in ci workflow #2095

Merged

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

It seems that markdown misspell check plugin is deprecated, so we use typos check instead.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 48.88889% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.35%. Comparing base (3713163) to head (7cd7b6f).
Report is 14 commits behind head on master.

Files Patch % Lines
...et/loadbalancerset/load_balancer_set_controller.go 0.00% 5 Missing ⚠️
...r/raven/gatewaypickup/gateway_pickup_controller.go 0.00% 4 Missing ⚠️
...roller/yurtappdaemon/yurt_app_daemon_controller.go 0.00% 4 Missing ⚠️
cmd/yurt-tunnel-agent/app/options/options.go 0.00% 1 Missing ⚠️
pkg/yurthub/certificate/token/token.go 0.00% 1 Missing ⚠️
pkg/yurthub/proxy/local/faketoken.go 0.00% 1 Missing ⚠️
pkg/yurthub/proxy/remote/loadbalancer.go 0.00% 1 Missing ⚠️
pkg/yurthub/proxy/util/util.go 0.00% 1 Missing ⚠️
...tiotdock/clients/edgex-foundry/v3/device_client.go 66.66% 1 Missing ⚠️
...daemon/workloadcontroller/deployment_controller.go 85.71% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
+ Coverage   56.09%   56.35%   +0.25%     
==========================================
  Files         186      188       +2     
  Lines       18092    18328     +236     
==========================================
+ Hits        10149    10329     +180     
- Misses       6910     6946      +36     
- Partials     1033     1053      +20     
Flag Coverage Δ
unittests 56.35% <48.88%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch force-pushed the replace-misspeel-with-typos-check branch 5 times, most recently from 540445e to 8c3282c Compare July 15, 2024 08:58
Signed-off-by: rambohe-ch <linbo.hlb@alibaba-inc.com>
@rambohe-ch rambohe-ch force-pushed the replace-misspeel-with-typos-check branch from 8c3282c to 7cd7b6f Compare July 15, 2024 09:03
@zyjhtangtang
Copy link
Contributor

/LGTM

@zyjhtangtang zyjhtangtang merged commit 4ea067d into openyurtio:master Jul 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants