Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve concurrent workers parameter for yurtappset controller #2087

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

By adding new startup parameter concurrent-yurtappset-worker for yurtappset controller

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@rambohe-ch rambohe-ch force-pushed the improve-yas-workers branch from a62989a to 478c693 Compare June 26, 2024 03:02
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.24%. Comparing base (3713163) to head (478c693).
Report is 8 commits behind head on master.

Files Patch % Lines
...r/controller/yurtappset/yurt_app_set_controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2087      +/-   ##
==========================================
+ Coverage   56.09%   56.24%   +0.14%     
==========================================
  Files         186      186              
  Lines       18092    18044      -48     
==========================================
  Hits        10149    10149              
+ Misses       6910     6864      -46     
+ Partials     1033     1031       -2     
Flag Coverage Δ
unittests 56.24% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyjhtangtang
Copy link
Contributor

LGTM

@zyjhtangtang zyjhtangtang merged commit da49fc4 into openyurtio:master Jun 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants