Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add forwardkubesvctraffic filter and adapt server certificate #1996
add forwardkubesvctraffic filter and adapt server certificate #1996
Changes from all commits
9f157d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 86 in pkg/yurthub/certificate/server/server.go
pkg/yurthub/certificate/server/server.go#L78-L86
Check warning on line 90 in pkg/yurthub/certificate/server/server.go
pkg/yurthub/certificate/server/server.go#L88-L90
Check warning on line 95 in pkg/yurthub/certificate/server/server.go
pkg/yurthub/certificate/server/server.go#L92-L95
Check warning on line 109 in pkg/yurthub/certificate/server/server.go
pkg/yurthub/certificate/server/server.go#L97-L109
Check warning on line 114 in pkg/yurthub/certificate/server/server.go
pkg/yurthub/certificate/server/server.go#L112-L114
Check warning on line 46 in pkg/yurthub/filter/forwardkubesvctraffic/filter.go
pkg/yurthub/filter/forwardkubesvctraffic/filter.go#L45-L46
Check warning on line 73 in pkg/yurthub/filter/forwardkubesvctraffic/filter.go
pkg/yurthub/filter/forwardkubesvctraffic/filter.go#L72-L73
Check warning on line 82 in pkg/yurthub/filter/forwardkubesvctraffic/filter.go
pkg/yurthub/filter/forwardkubesvctraffic/filter.go#L81-L82
Check warning on line 103 in pkg/yurthub/filter/forwardkubesvctraffic/filter.go
pkg/yurthub/filter/forwardkubesvctraffic/filter.go#L101-L103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to replace it with following:
which in pkg
"k8s.io/utils/pointer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems not updated? @rambohe-ch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the definition of
trueCondition
is improved bypointer.Bool(true)
.