[GPU] Expose caching DebugOptions to python #15636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-m
force-pushed
the
cache-python
branch
2 times, most recently
from
a75829b
to
207bcc6
Compare
cheshire
requested changes
Aug 2, 2024
Thanks for reviewing, added test to |
skye
approved these changes
Aug 6, 2024
| @@ -3137,6 +3137,9 @@ def testCompileOptionsSerialization(self): | |||
| executable_build_options.num_partitions = 2 | |||
| executable_build_options.debug_options.xla_cpu_enable_fast_math = True | |||
| executable_build_options.debug_options.xla_test_all_input_layouts = True | |||
| executable_build_options.debug_options.xla_gpu_kernel_cache_file = "/foo/bar" | |||
There was a problem hiding this comment.
I think you actually need to test these flags by adding them to L3157
There was a problem hiding this comment.
Thanks for the review! Fixed this.
cheshire
approved these changes
Aug 20, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 20, 2024
Imported from GitHub PR openxla/xla#15636 Adds python bindings for `xla_gpu_kernel_cache_file`, `xla_gpu_enable_llvm_module_compilation_parallelism` and `xla_gpu_per_fusion_autotune_cache_dir`. We would like to add some convenience features to JAX which will enable all caches with one flag/option (will open PR for that soon). This change is necessary for that. Copybara import of the project: -- 87dbb3d3abe5969d1509d965071c5c7dbdcb46d0 by Trevor Morris <tmorris@nvidia.com>: Expose caching DebugOptions to python -- 3bb41fca800bc12d00870e7b8cbde3641de9beab by Trevor Morris <tmorris@nvidia.com>: Add test -- f0e04233522d8740c83b9b19138b76304b242604 by Trevor Morris <tmorris@nvidia.com>: Fix tests Merging this change closes #15636 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15636 from trevor-m:cache-python f0e04233522d8740c83b9b19138b76304b242604 PiperOrigin-RevId: 665300777
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 20, 2024
Imported from GitHub PR openxla/xla#15636 Adds python bindings for `xla_gpu_kernel_cache_file`, `xla_gpu_enable_llvm_module_compilation_parallelism` and `xla_gpu_per_fusion_autotune_cache_dir`. We would like to add some convenience features to JAX which will enable all caches with one flag/option (will open PR for that soon). This change is necessary for that. Copybara import of the project: -- 87dbb3d3abe5969d1509d965071c5c7dbdcb46d0 by Trevor Morris <tmorris@nvidia.com>: Expose caching DebugOptions to python -- 3bb41fca800bc12d00870e7b8cbde3641de9beab by Trevor Morris <tmorris@nvidia.com>: Add test -- f0e04233522d8740c83b9b19138b76304b242604 by Trevor Morris <tmorris@nvidia.com>: Fix tests Merging this change closes #15636 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15636 from trevor-m:cache-python f0e04233522d8740c83b9b19138b76304b242604 PiperOrigin-RevId: 665300777
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 20, 2024
Imported from GitHub PR openxla/xla#15636 Adds python bindings for `xla_gpu_kernel_cache_file`, `xla_gpu_enable_llvm_module_compilation_parallelism` and `xla_gpu_per_fusion_autotune_cache_dir`. We would like to add some convenience features to JAX which will enable all caches with one flag/option (will open PR for that soon). This change is necessary for that. Copybara import of the project: -- 87dbb3d3abe5969d1509d965071c5c7dbdcb46d0 by Trevor Morris <tmorris@nvidia.com>: Expose caching DebugOptions to python -- 3bb41fca800bc12d00870e7b8cbde3641de9beab by Trevor Morris <tmorris@nvidia.com>: Add test -- f0e04233522d8740c83b9b19138b76304b242604 by Trevor Morris <tmorris@nvidia.com>: Fix tests Merging this change closes #15636 PiperOrigin-RevId: 665475870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds python bindings for
xla_gpu_kernel_cache_file,xla_gpu_enable_llvm_module_compilation_parallelismandxla_gpu_per_fusion_autotune_cache_dir.We would like to add some convenience features to JAX which will enable all caches with one flag/option (will open PR for that soon). This change is necessary for that.