shared/ConnId: Fix logic error in constructor #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geonnave
reviewed
May 13, 2024
|
Looks good, left one comment, thanks. |
This fixes a copy-paste error stemming from using code from from_int_raw without inverting the conditions, and adds documentation including doctests on this and related methods.
chrysn
force-pushed
the
connid-from-slice-fix-and-doc
branch
from
774ee8f to
4192eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a copy-paste error stemming from using code from from_int_raw without inverting the conditions, and adds documentation including doctests on this and related methods.
This fixes a bug introduced in #260 that was not covered by tests (because the tests do not try the path where the initiator deliberately chooses a C_I)