-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EADs to not use global state #170
Refactor EADs to not use global state #170
Conversation
e5e6148
to
79cd4a3
Compare
The new |
@chrysn I tried to use the typestate pattern here, could you please take a look? (see the 2 commits with "typestatify" in the name") |
0633117
to
4fd0db3
Compare
also handles loc_w and voucher_request back to the application instead of saving it internally on state. this enables the application to perform the network request in any way it wants to do that.
4fd0db3
to
8b12f33
Compare
The typestatification looks about right (as far as I can tell that from mainly looking at types and signatures). It looks like there are fewer types than there were enum states before, but apparently not all were used. Is ZeroTouchAuthenticatorState left around on purpose? |
Thank you for the review.
Yes, some were unused and the I can't find the symbol |
This is a step in the direction of the separate message processing, initially discussed in #99, and further discussed in the meeting this week.
Edit: this includes:
dyn
or some crazy generic stuff)