Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to lakers #165

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

chrysn
Copy link
Collaborator

@chrysn chrysn commented Dec 6, 2023

Picking "lakers" as discussed in today's call with @malishav and @geonnave. This PR only renames the crates that'd actually go to crates.io, and uses

  • "edhoc-rs" => "lakers"
  • "edhoc-consts" => "lakers-shared" (because it's not really constants any more; that's a pending rename anyway)
  • "edhoc-crypto-rustcrypto" => "lakers-crypto-rustcrypto" (which so far is the only backend that doesn't need patching and can go up as a publicly usable reference)
  • "edhoc-ead" => "lakers-ead-dispatch" (edhoc-crypto would be renamed to edhoc-crypto-dispatch too, because that's what they do)
  • "edhoc-ead-none" => "lakers-ead-none"
  • "edhoc-ead-zeroconf" => "lakers-ead-zeroconf"

All the renaming is for now purely local to the Cargo.toml files; inside Rust no identifiers are replaced. We'll probably want to do that at some point in time, but that's best done on a flag day when nobody has any pending PRs or (worse) local changes, as that's a big search-and-replace (and may make sense together with directory renaming etc).

I'll probably need one or two iterations on CI to fix mentions of names I haven't found in local testing.

* "edhoc-rs" => "lakers"
* "edhoc-consts" => "lakers-shared"
* "edhoc-crypto-rustcrypto" => "lakers-crypto-rustcrypto"
* "edhoc-ead" => "lakers-ead-dispatch"
* "edhoc-ead-none" => "lakers-ead-none"
* "edhoc-ead-zeroconf" => "lakers-ead-zeroconf"
@chrysn
Copy link
Collaborator Author

chrysn commented Dec 6, 2023

CI passes, marking this ready-for-review.

Versions are still as 0.4.0-alpha.1, which I think makes sense for a first upload.

With that, first uploads should be possible any time (especially given the alpha version number). The first upload is probably where we'll find that some properties of the crates are not yet matching crates.io's expectations -- can I just go ahead and upload, so that we can then figure out a more long-term release ... aehm, layup process?

@chrysn chrysn marked this pull request as ready for review December 6, 2023 14:56
@geonnave
Copy link
Collaborator

geonnave commented Dec 6, 2023

This looks good to me. lakers-shared is indeed more aligned with its current functionality, and ead-dispatch too. I think I am missing the reason for not renaming edhoc-crypto to lakers-crypto-dispatch.

@chrysn
Copy link
Collaborator Author

chrysn commented Dec 6, 2023 via email

@geonnave
Copy link
Collaborator

geonnave commented Dec 6, 2023

Sounds good!

@chrysn chrysn mentioned this pull request Dec 6, 2023
@geonnave geonnave merged commit 2e5e9aa into openwsn-berkeley:main Dec 8, 2023
@chrysn chrysn deleted the lakers branch December 8, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants