refactor: remove unneeded trait for EdhocMessageBuffer

consts/src/lib.rs

@@ -165,8 +165,6 @@ pub struct EdhocMessageBuffer {
     pub len: usize,
 }
 
-impl EdhocMessageBuffer {}
-
 impl Default for EdhocMessageBuffer {
     fn default() -> Self {
         EdhocMessageBuffer {
@@ -176,38 +174,30 @@ impl Default for EdhocMessageBuffer {
     }
 }
 
-pub trait MessageBufferTrait {
-    fn new() -> Self;
-    fn get(self, index: usize) -> Option<u8>;
-    fn get_slice<'a>(&'a self, start: usize, len: usize) -> Option<&'a [u8]>;
-    fn as_slice<'a>(&'a self) -> &'a [u8];
-    fn from_hex(hex: &str) -> Self;
-}
-
-impl MessageBufferTrait for EdhocMessageBuffer {
-    fn new() -> Self {
+impl EdhocMessageBuffer {
+    pub fn new() -> Self {
         EdhocMessageBuffer {
             content: [0u8; MAX_MESSAGE_SIZE_LEN],
             len: 0,
         }
     }
 
-    fn get(self, index: usize) -> Option<u8> {
+    pub fn get(self, index: usize) -> Option<u8> {
         match self.content.get(index) {
             Some(b) => Some(*b),
             _ => None,
         }
     }
 
-    fn get_slice<'a>(&'a self, start: usize, len: usize) -> Option<&'a [u8]> {
+    pub fn get_slice<'a>(&'a self, start: usize, len: usize) -> Option<&'a [u8]> {
         self.content.get(start..len)
     }
 
-    fn as_slice<'a>(&'a self) -> &'a [u8] {
+    pub fn as_slice<'a>(&'a self) -> &'a [u8] {
         &self.content[0..self.len]
     }
 
-    fn from_hex(hex: &str) -> Self {
+    pub fn from_hex(hex: &str) -> Self {
         let mut buffer = EdhocMessageBuffer::new();
         buffer.len = hex.len() / 2;
         for (i, chunk) in hex.as_bytes().chunks(2).enumerate() {

crypto/edhoc-crypto-rustcrypto/src/lib.rs

@@ -3,7 +3,7 @@
 use edhoc_consts::{
     BufferCiphertext3, BufferPlaintext3, BytesCcmIvLen, BytesCcmKeyLen, BytesHashLen,
     BytesMaxBuffer, BytesMaxInfoBuffer, BytesP256ElemLen, Crypto as CryptoTrait, EDHOCError,
-    MessageBufferTrait, AES_CCM_TAG_LEN, MAX_BUFFER_LEN,
+    AES_CCM_TAG_LEN, MAX_BUFFER_LEN,
 };
 
 use ccm::AeadInPlace;