#133: Avoid code duplication in process_message_2 and process_message_3 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geonnave
approved these changes
Nov 8, 2023
lib/src/edhoc.rs
Outdated
| public_key = public_key_expected; | ||
| let credentials_match = match id_cred_received { | ||
| IdCred::CompactKid(kid) => kid == kid_expected, | ||
| IdCred::FullCredential(cred_received) => credential_expected == cred_received, |
There was a problem hiding this comment.
For consistency we could have:
IdCred::CompactKid(kid_received) => kid_received == kid_expected,
IdCred::FullCredential(cred_received) => credential_received == credential_expected,
… process_message_3
malishav
force-pushed
the
133-refactor_process_message_2_3
branch
from
fc54564 to
c8e1731
Compare
Merged
geonnave
added a commit
that referenced
this pull request
Nov 15, 2023
To solve conflicts with main, I had to temporarily overwrite the changes of PR #134 (avoid code duplication). This will be solved in a follow up commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes common code between
process_message_2andprocess_message_3into a singlecredential_check_or_fetchfunction. This is a first step to modularizing the steps that need to be done by the application code in terms of authentication credential processing.