Skip to content

Conversation

@l-jonas
Copy link

@l-jonas l-jonas commented Dec 27, 2025

📦 Package Details

Maintainer: no one to ping as this is a new package

Description: This integrates mwan3 with munin to observe uptimes and downtimes


🧪 Run Testing Details

  • OpenWrt Version: v25.12.0-rc1
  • OpenWrt Target/Subtarget: x86/x86_64
  • OpenWrt Device: Generic x86/64

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

not applicable

This integrates mwan3 with munin to observe uptimes and downtimes.

Signed-off-by: Jonas Lochmann <openwrt@jonaslochmann.de>
@l-jonas l-jonas force-pushed the add-munin-mwan branch 2 times, most recently from 377c27b to b965719 Compare December 27, 2025 20:19
@BKPepe
Copy link
Member

BKPepe commented Dec 28, 2025

Shouldn't it be added to https://github.com/munin-monitoring/muninlite into the plugins folder first? 🤔

@l-jonas
Copy link
Author

l-jonas commented Dec 28, 2025

The scope of muninlite is "It provides a small set of essential plugins suitable for basic monitoring of a host.". The mwan3 integration does not belong to this category. muninlite is unrelated to OpenWrt, while mwan3 is not, so a plugin for this does not at all belong there.

@BKPepe
Copy link
Member

BKPepe commented Dec 28, 2025

Look, honestly, I don't really understand why this muninlite plugin needs its own separate package. The source code for muninlite plugins is in the upstream repo, then we'd have another plugin in downstream, and then another one somewhere else. This doesn't seem like the right way to handle it.

Users should be able to decide which plugins they want, but it would be better to handle this via subpackages within muninlite so everything is in one place. Also, you are missing a dependency on mwan3.

The solution is simply to keep the plugins in upstream and use the Makefile to handle subpackages (copying files and adding dependencies). Right now, only the plugin directory is being created, but the files aren't actually copied into it.

Finally, it doesn't make sense for the source code to be here. The review should happen upstream with the developers who are actually familiar with the code.

@l-jonas
Copy link
Author

l-jonas commented Dec 28, 2025

The source for muninlite plugins that fit the muninlite scope as described in its Readme belong to the upstream repository. This plugin does not meet the requirements.

Actually, the plugin directory of the muninlite source code is not for actual plugins as this is compiled into the muninlite script and those plugins are not installable one by one.

I can keep this package in my OpenWrt fork without upstreaming it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants