tcpreplay: add libbpf dependency #27883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleostnacl
force-pushed
the
fix_tcpreply_dependency
branch
from
1488fa6 to
2d7d46b
Compare
Since compiling tcpbridge requires linking libbpf.so.1, compiling tcpbridge first may result in compilation failure, like: Package tcpbridge is missing dependencies for the following libraries: libbpf.so.1 The simplest way to solve it is to add libbpf dependency in Makefile Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
teleostnacl
force-pushed
the
fix_tcpreply_dependency
branch
from
2d7d46b to
795bdac
Compare
Contributor
|
Tcpreplay compiles ok in buildbot (with all libraries supposedly present), so I wonder about your findings about a missing dependency. |
Contributor
Looking into I'm fine to have this be a dependency of |
commodo
reviewed
Nov 16, 2025
| URL:=http://tcpreplay.appneta.com/ | ||
| MAINTAINER:=Alexandru Ardelean <ardeleanalex@gmail.com> | ||
| DEPENDS:=+librt +libpcap +libdnet +USE_MUSL:musl-fts | ||
| DEPENDS:=+librt +libpcap +libdnet +libbpf +USE_MUSL:musl-fts |
Contributor
There was a problem hiding this comment.
are you sure libbpf will be used ?
if i look into
CONFIGURE_ARGS += \
--enable-force-pf \
...................
This will force PF_PACKET over libbpf.
So, libbpf will be pulled as a dependency, but will not be used by tcpreplay.
commodo
requested changes
Nov 16, 2025
Contributor
commodo
left a comment
commodo
left a comment
There was a problem hiding this comment.
This would need a Config.in option, where libbpf is chosen in a menuconfig.
By default, PF_PACKET is used (standard Linux kernel socket filtering).
libbpf may be a bit more feature-rich, but currently it needs more changes to work.
Contributor
Author
|
Hello @commodo Meanwhile, here are some adds: When I select The wrong message is The I use ArchLinux to compile OpenWrt. |
Contributor
Oh Give me a few days to look into this. |
Contributor
Author
|
I have another device:
In this device, I don't select libbpf package, but I also compile tcpreplay failed, and the output like this: It also tells me |
Contributor
|
Will close this PR. I would like to do something like this: #28024 |
Contributor
|
turns out this is the simplest approach; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since compiling tcpbridge requires linking libbpf.so.1, compiling tcpbridge first may result in compilation failure, like:
Package tcpbridge is missing dependencies for the following libraries: libbpf.so.1
The simplest way to solve it is to add libbpf dependency in Makefile
📦 Package Details
Maintainer: Alexandru Ardelean ardeleanalex@gmail.com
Description:
Add a dependency on libbpf in tcprepaly
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am