Skip to content

bind: prevent mismatch of bind-libs version #26800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matjon wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −2
Open

bind: prevent mismatch of bind-libs version #26800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions net/bind/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=bind
PKG_VERSION:=9.20.15
PKG_RELEASE:=3
PKG_RELEASE:=4
USERID:=bind=57:bind=57

PKG_MAINTAINER:=Noah Meyerhans <frodo@morgul.net>
Expand Down Expand Up @@ -49,6 +49,7 @@ define Package/bind/Default
SECTION:=net
CATEGORY:=Network
DEPENDS:=+bind-libs +@OPENSSL_WITH_EC
EXTRA_DEPENDS:=bind-libs (=$(PKG_VERSION)-r$(PKG_RELEASE))
Copy link
Contributor

@nmeyerhans nmeyerhans Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be in EXTRA_DEPENDS, or can the version constraint be added in DEPENDS?

Copy link
Author

@matjon matjon Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://openwrt.org/docs/guide-developer/packages#dependency_types suggests that EXTRA_DEPENDS is necessary.

When I try to use something like

  DEPENDS:=+bind-libs(=$(PKG_VERSION)-r$(PKG_RELEASE)) +@OPENSSL_WITH_EC

or

  DEPENDS:=+bind-libs (=$(PKG_VERSION)-r$(PKG_RELEASE)) +@OPENSSL_WITH_EC

I get immediately errors similar to:

WARNING: Makefile 'package/feeds/packages/bind/Makefile' has a dependency on 'bind-libs(=9.20.9-r4)', which does not exist

TITLE:=bind
URL:=https://www.isc.org/software/bind
SUBMENU:=IP Addresses and Names
Expand Down Expand Up @@ -78,6 +79,7 @@ define Package/bind-server
TITLE+= DNS server
DEPENDS+= +libcap \
+bind-rndc
EXTRA_DEPENDS+=, bind-rndc (=$(PKG_VERSION)-r$(PKG_RELEASE))
endef

define Package/bind-server/config
Expand All @@ -87,6 +89,7 @@ endef
define Package/bind-server-filter-aaaa
$(call Package/bind-server)
DEPENDS:=bind-server
EXTRA_DEPENDS:=bind-server (=$(PKG_VERSION)-r$(PKG_RELEASE))
TITLE+= filter AAAA plugin
endef

Expand All @@ -98,14 +101,22 @@ endef
define Package/bind-tools
$(call Package/bind/Default)
TITLE+= administration tools (all)
DEPENDS:= \
DEPENDS:= \
+bind-check \
+bind-dig \
+bind-nslookup \
+bind-dnssec \
+bind-host \
+bind-rndc \
+bind-ddns-confgen
EXTRA_DEPENDS:= \
bind-check (=$(PKG_VERSION)-r$(PKG_RELEASE)), \
bind-dig (=$(PKG_VERSION)-r$(PKG_RELEASE)), \
bind-nslookup (=$(PKG_VERSION)-r$(PKG_RELEASE)), \
bind-dnssec (=$(PKG_VERSION)-r$(PKG_RELEASE)), \
bind-host (=$(PKG_VERSION)-r$(PKG_RELEASE)), \
bind-rndc (=$(PKG_VERSION)-r$(PKG_RELEASE)), \
bind-ddns-confgen (=$(PKG_VERSION)-r$(PKG_RELEASE))
endef

define Package/bind-rndc
Expand Down