Skip to content

yt-dlp: run CI test for the main package only#26335

Merged
1715173329 merged 1 commit intoopenwrt:masterfrom
GeorgeSapkin:yt-dlp-fix-ci-tests
Apr 24, 2025
Merged

yt-dlp: run CI test for the main package only#26335
1715173329 merged 1 commit intoopenwrt:masterfrom
GeorgeSapkin:yt-dlp-fix-ci-tests

Conversation

@GeorgeSapkin
Copy link
Copy Markdown
Member

@GeorgeSapkin GeorgeSapkin commented Apr 16, 2025

Maintainer: me
Compile tested: mediatek/filogic, 24.10.1 SDK
Run tested: not needed

Description:

Fix failing CI test for the source package in stable: the test should apply to the main package only.

Fixes the issue from #26333

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Apr 17, 2025

Would be good if you use Fixes tag in the commit description.

@GeorgeSapkin
Copy link
Copy Markdown
Member Author

@BKPepe I probably misunderstood what you meant, but the link in the description points to a PR with a failing pipeline (and not a separate issue), so doing the usual Fixes: #26333 in the commit doesn't really make sense to me. But I don't have a strong opinion about it either way.

@thom24
Copy link
Copy Markdown
Contributor

thom24 commented Apr 17, 2025

It is definitely better to have Fixes tag in the commit message, but it must refer to a commit id (the one which introduced the bug) and not a PR id and contains the one line summary.
For example: Fixes: 5cb12d4 ("modemmanager: add config optional netifd integration")
So you know which commit is fixed only using the git repository. If for any reason GitHub is not used anymore in the future, you do not lose the information.

@GeorgeSapkin
Copy link
Copy Markdown
Member Author

@thom24 thanks. Makes sense.

Fixes: afe9935 ("yt-dlp: add CI version check")
Signed-off-by: George Sapkin <george@sapk.in>
@1715173329 1715173329 merged commit 6746398 into openwrt:master Apr 24, 2025
12 checks passed
@GeorgeSapkin GeorgeSapkin deleted the yt-dlp-fix-ci-tests branch April 24, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants