treewide, affected packages: fix build with golang 1.16#14886
treewide, affected packages: fix build with golang 1.16#14886neheb merged 8 commits intoopenwrt:masterfrom
Conversation
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
|
LGTM |
|
It doesn't look like the But the others LGTM. |
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Add GO111MODULE=auto to GO_PKG_BUILD_VARS to allow the package to be built in non-module mode. Module-aware mode will be mandatory in the next golang release. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
|
|
|
@cotequeiroz , @jefferyto since we are now using Golang 1.21 in OpenWrt master branch and as well OpenWrt 23.05, we can drop |
|
It depends on each affected package, if they have updated to using Go modules. I think most Go projects have switched, though I believe docker still has not. tor-fw-helper has not but it also hasn't been updated in years; maybe it would be better to remove that package entirely instead. |
|
After two years? Definitely, they updated it. If not, it needs to be reported to them. That sounds like easy job, isn't it? :) Ok, let's drop |
|
Maintainers: @gekmihesg @jefferyto @dangowrt @aparcar @G-M0N3Y-2503
Compile tested: mvebu, arm_cortex-a9+vfpv3-d16, openwrt master
Run tested: none
Description:
Golang 1.16 changed the default package build mode to "module-aware" mode. The intention is to drop GOPATH mode (opposite of module-aware) in go 1.17. See https://blog.golang.org/go116-module-changes
To enable GOPATH mode, this PR adds
GO111MODULE=autotoGO_PKG_BUILD_VARS. Affected packages areSample error messages
Fixes #14879