Skip to content

CI: generic runtime tests #13785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aparcar wants to merge 2 commits into from
Closed

CI: generic runtime tests #13785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5366e19
CI: run generic version test for all pacakges
aparcar Oct 27, 2020
205f242
vim: remove generic test.sh
aparcar Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion .github/workflows/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,34 @@ for PKG in /ci/*.ipk; do
exit 1
fi
else
echo "No test.sh script available"
echo "Use generic test"
PKG_FILES=$(opkg files "$PKG_NAME" | grep -E "/bin|/sbin|/usr/bin|/usr/sbin")
Copy link
Copy Markdown
Member

@GeorgeSapkin GeorgeSapkin Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PKG_FILES=$(opkg files "$PKG_NAME" | grep -E "/bin|/sbin|/usr/bin|/usr/sbin")
PKG_FILES=$(opkg files "$PKG_NAME" | grep -E "/bin|/sbin|/usr/bin|/usr/sbin")

Copy link
Copy Markdown
Member

@wehagy wehagy Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need apk info -L support

SUCCESS=0
FOUND_EXE=0
for FILE in $PKG_FILES; do
if [ -x "$FILE" ] && [ -f "$FILE" ]; then
FOUND_EXE=1
echo "Test executable $FILE"
for V in --version -version version -v -V; do
echo "Trying $FILE $V"
if "$FILE" "$V" 2>&1 | grep "$PKG_VERSION"; then
SUCCESS=1
break
fi
done
Comment on lines +43 to +49
Copy link
Copy Markdown
Member

@GeorgeSapkin GeorgeSapkin Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ensuring the main binary can display help should be enough for a success already, as a last resort after the version checks. This at least checks that binaries are valid and have the linked dependencies installed.

Also I think it makes sense to do grep -F if that's not the default.

Copy link
Copy Markdown
Member

@wehagy wehagy Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ensuring the main binary can display help should be enough for a success already, as a last resort after the version checks. This at least checks that binaries are valid and have the linked dependencies installed

The problem is how? Because not all packages use exit 0 as a return. Maybe we can use grep to check the binary name itself?

Copy link
Copy Markdown
Member

@GeorgeSapkin GeorgeSapkin Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant on top of --version -version version -v -V do something like --help, etc. Worst case scenario somebody's PR fails and they add a proper test.

Might be a good idea to also do an ldd (if it's a binary) and check if any linked dependencies are missing. And do this even if packages have their own tests.


fi
done
if [ "$FOUND_EXE" -eq 1 ]; then
if [ "$SUCCESS" -eq 0 ]; then
echo "Generic test failed"
exit 1
else
echo "Test succesful or"
Copy link
Copy Markdown
Member

@BKPepe BKPepe Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be without or?

Suggested change
echo "Test succesful or"
echo "Test successful"

fi
else
echo "No executeable found in package $PKG_NAME"
Copy link
Copy Markdown
Member

@BKPepe BKPepe Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "No executeable found in package $PKG_NAME"
echo "No executable found in package $PKG_NAME"

fi
fi

opkg remove "$PKG_NAME" --force-removal-of-dependent-packages --force-remove
Expand Down
7 changes: 0 additions & 7 deletions utils/vim/test.sh
View file
Open in desktop

This file was deleted.