luci-app-watchcat: revert multiple pinghosts support #8171
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
3 tasks
This change introduced support for multiple ping hosts, but due to inconsistent argument handling with the backend, it results in broken behavior. As part of this revert, the pinghosts option is disabled in LUCI to restore the previous, known-working behavior. This aligns LUCI with the current backend until a proper fix is implemented. Signed-off-by: Ivan Diaz <diaz.it@icloud.com>
ivanddiaz
force-pushed
the
luci-watchcat-revert
branch
from
2383b2f to
75dabb3
Compare
ivanddiaz
referenced
this pull request
in openwrt/packages
Dec 23, 2025
The backend now correctly supports multiple IP addresses and avoids argument shifting when mmifacename is empty. Signed-off-by: Ivan Diaz <diaz.it@icloud.com>
1 task
Author
|
I’m closing this PR based on the discussion here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduced support for multiple ping hosts, but due to inconsistent argument handling with the backend, it results in broken behavior.
As part of this revert, the pinghosts option is disabled in LUCI to restore the previous, known-working behavior. This aligns LUCI with the current backend until a proper fix is implemented.
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile