24.10.1 issues: reload_versions needs a trigger to fire when new release is made

[efahl]

@aparcar

All those "24.10.1 is missing" issues are due to lack of something that fires off reload_versions when the upstream .versions.json gets a new entry. Currently we're only calling reload_versions once at startup, but it needs to happen sporadically, too.

(I'll dig into it, but it might take a few days as I'm just back from a week away dealing with family issues and I'm pretty burnt out.)

[efahl]

Ok, looks like caching is on? And this line is causing the updates to be ignored? We probably need a clock on there, disable the from_cache for this item every 12 hours or something...

https://github.com/openwrt/asu/blob/main/asu/util.py#L440

[laurentftech]

I also noticed that 24.10.1 is missing here:

https://sysupgrade.openwrt.org

[dc366]

One solution is to put a default ttl in client_get. This will keep the cache from becoming stale. Redis caches things permanently unless told otherwise.

https://github.com/openwrt/asu/blob/main/asu/util.py#L35

def client_get(url: str, ttl: int = 3600) -> Response:
    return hishel.CacheClient(
        storage=hishel.RedisStorage(client=get_redis_client(False),ttl=ttl),
        controller=hishel.Controller(always_revalidate=True, allow_heuristics=True),
    ).get(url)

You can vary ttl in the functions which call client_get if desired.

[dc366]

I also think there is an optimization opportunity here - get_redis_client creates a new client on each request, it would be more efficient to create it once.

[AreYouLoco]

@efahl do you mind mentioning something in the issue title about problem with 24.10.1 and pin that issue?

https://docs.github.com/en/issues/tracking-your-work-with-issues/administering-issues/pinning-an-issue-to-your-repository

So maybe there is a chance less people will report more duplicates which is extra work for repo owners to do.