Skip to content

Formality check - limit to 75 and add exemption for Fixes: to follow kernel workflow #89

@GoetzGoerisch

Description

@GoetzGoerisch

Currently the limit for the subject is 60 which is to short if a fix reverts a kernel commit.

Furthermore the 75 char limit is enforced on the body with no exemption.
Thus properly formatted commits following the kernel style are failing the CI check.

  • Subject limit should be increased
  • Fixes: should be exempt in body from 75 char limit to match kernel workflow.

From the kernel documentation [1]:

If your patch fixes a bug in a specific commit, e.g. you found an issue using git bisect, please use the ‘Fixes:’ tag with at least the first 12 characters of the SHA-1 ID, and the one line summary. Do not split the tag across multiple lines, tags are exempt from the “wrap at 75 columns” rule in order to simplify parsing scripts. For example:
Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return the number of pages it actually freed")

1

Example: openwrt/openwrt@029f8ef

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions