Skip to content

Comments

Dashboard style cleanup#307

Merged
jamescmartinez merged 1 commit intomainfrom
dashboard-code-style-improvements
Feb 14, 2026
Merged

Dashboard style cleanup#307
jamescmartinez merged 1 commit intomainfrom
dashboard-code-style-improvements

Conversation

@jamescmartinez
Copy link
Contributor

Closes #191

Copilot AI review requested due to automatic review settings February 14, 2026 22:01
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements code style improvements for the dashboard by replacing hardcoded Tailwind colors with semantic CSS variables and standardizing className concatenation using the cn() utility, addressing issue #191.

Changes:

  • Added semantic CSS variables (success, info, warning, sleeping, neutral) to replace native Tailwind colors (green-500, blue-500, etc.)
  • Replaced all hardcoded Tailwind color classes with semantic equivalents throughout status configurations
  • Standardized className concatenation by replacing template literals with the cn() utility function

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/dashboard/src/styles.css Added five new semantic CSS variables for both light and dark themes and exposed them via @theme inline
packages/dashboard/src/lib/status.ts Replaced all hardcoded Tailwind color classes (text-green-500, bg-blue-500/10, etc.) with semantic variables (text-success, bg-info/10, etc.)
packages/dashboard/src/components/run-list.tsx Added cn() import and replaced template literal className concatenation with cn() utility
packages/dashboard/src/routes/runs/$runId.tsx Replaced template literal className concatenation with cn() utility for three instances (Badge and CaretDownIcon components)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamescmartinez jamescmartinez merged commit eac4b1c into main Feb 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard code style improvements

1 participant