Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR implements code style improvements for the dashboard by replacing hardcoded Tailwind colors with semantic CSS variables and standardizing className concatenation using the cn() utility, addressing issue #191.
Changes:
- Added semantic CSS variables (success, info, warning, sleeping, neutral) to replace native Tailwind colors (green-500, blue-500, etc.)
- Replaced all hardcoded Tailwind color classes with semantic equivalents throughout status configurations
- Standardized className concatenation by replacing template literals with the
cn()utility function
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/dashboard/src/styles.css | Added five new semantic CSS variables for both light and dark themes and exposed them via @theme inline |
| packages/dashboard/src/lib/status.ts | Replaced all hardcoded Tailwind color classes (text-green-500, bg-blue-500/10, etc.) with semantic variables (text-success, bg-info/10, etc.) |
| packages/dashboard/src/components/run-list.tsx | Added cn() import and replaced template literal className concatenation with cn() utility |
| packages/dashboard/src/routes/runs/$runId.tsx | Replaced template literal className concatenation with cn() utility for three instances (Badge and CaretDownIcon components) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191