[chores:fix] Commitizen: added unhandled valid cases, moved code to releaser/ dir #110#590
[chores:fix] Commitizen: added unhandled valid cases, moved code to releaser/ dir #110#590nemesifier merged 2 commits intomasterfrom
Conversation
This case wasn't handled properly. Related to #110
WalkthroughThe changes relocate the OpenWispCommitizen class from a standalone module (cz_openwisp.py) to the openwisp_utils/releaser/commitizen.py package structure. The entry point in setup.py is updated to reference the new location. The commit message validation pattern is extended to accept multiple verb forms (Close, Closes, Closed, Fix, Fixes, Fixed, Resolve, Resolves, Resolved, Related to) before issue numbers. Corresponding tests are added for the new verb forms, and the old test module reference is removed from the test runner configuration. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2026-02-06T20:46:32.980ZApplied to files:
🧬 Code graph analysis (1)openwisp_utils/releaser/tests/test_commitizen_rules.py (1)
🪛 Ruff (0.14.14)openwisp_utils/releaser/tests/test_commitizen_rules.py[warning] 46-46: Unpacked variable Prefix it with an underscore or any other dummy variable pattern (RUF059) [warning] 46-46: Unpacked variable Prefix it with an underscore or any other dummy variable pattern (RUF059) [warning] 57-57: Unpacked variable Prefix it with an underscore or any other dummy variable pattern (RUF059) [warning] 57-57: Unpacked variable Prefix it with an underscore or any other dummy variable pattern (RUF059) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
🔇 Additional comments (3)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Checklist
Reference to Existing Issue
Related to #110.
Description of Changes
Added unhandled valid cases, the reference to issue was allowing only "Fixes", but we need more cases like "Closes", "Related to" and other typical cases allowed by github.
I also moved the commitizen logic to the releaser/ dir so we can keep all the release management logic in one place.