[fix] Updated system info to retrieve friendly OS identifiers #544 #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "distro" package as dependency. Fixes #544
github-project-automation
bot
moved this to To do (general)
in OpenWISP Contributor's Board
Member
Author
|
The platform.freedesktop_os_release is only available on Python 3.10+. In order to make this change backportable to 1.2 version (which supports Python 3.9), I have added an additional dependency to distro package. We can also add a conditional to only use |
nemesifier
approved these changes
Dec 19, 2025
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Looks good, let's test this before merging.
github-project-automation
bot
moved this from To do (general)
to In progress
in OpenWISP Contributor's Board
github-project-automation
bot
moved this from In progress
to Done
in OpenWISP Contributor's Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Fixes #544
Description of Changes
Added "distro" package as dependency.
Screenshot