Skip to content

Conversation

@AditiSah05
Copy link

@AditiSah05 AditiSah05 commented Dec 6, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #533

Please open a new issue if there isn't an existing issue yet.

Description of Changes

Issue
Select2 autofilter had inconsistent colors compared to regular filters in admin interface.

Fix
Updated openwisp_utils/admin_theme/static/admin/css/ow-auto-filter.css:

Changed active border color from var(--ow-selected-filter-option-bg) to var(--ow-active-filter-title)
Added consistent line height for placeholder text
Result
✅ Select2 autofilters now match regular filter appearance
✅ No impact on change forms
✅ All tests pass

@AditiSah05
Copy link
Author

Hi @okraits,
I hope you're doing well.

I recently opened a PR — fix/[bug:ui] Select2 autofilter look is inconsistent with other filters (#541) — which closes issue #533. I’ve addressed the styling inconsistencies between Select2 autofilters and the regular admin filters and ensured tests and functionality remain unaffected.

Whenever you have time, could you please take a look and let me know if any changes are needed? Your feedback would be really helpful as I’m still getting familiar with the codebase.

Thank you!

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch does not solve the issue. I am closing for now, feel free to reopen if you come up with an actual solution.

@nemesifier nemesifier closed this Dec 19, 2025
@AditiSah05 AditiSah05 deleted the fix-bug branch December 19, 2025 17:12
@AditiSah05
Copy link
Author

Hi @nemesifier,
thank you for taking the time to review the PR and for the feedback.

I understand that the current patch doesn’t fully resolve the underlying issue. I’ll revisit the problem, dig deeper into the root cause of the Select2 autofilter inconsistency, and work on a more accurate solution. Once I have a proper fix, I’ll reopen the issue with an updated approach.

Eeshu-Yadav added a commit to Eeshu-Yadav/openwisp-utils that referenced this pull request Jan 31, 2026
I've created four GitHub Actions workflow files to automate issue assignment/unassignment.

Created Workflows:
1. issue-assignment.yml – Auto-response to 'assign me' requests
2. pr-issue-link.yml – Auto-assign on PR
3. stale-pr-management.yml – Stale PR management (tracks contributor inactivity only)
4. pr-reopen-reassign.yml – Handle contributor follow-up

Fixes openwisp#541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug:ui] Select2 autofilter look is inconsistent with other filters

2 participants