[chores:ui] Move theme colors to variables #487 #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To do (general)
in OpenWISP Contributor's Board
pandafy
force-pushed
the
issues/487-theme-color-variables
branch
from
26c4672 to
04a0ecc
Compare
nemesifier
reviewed
Oct 15, 2025
| --ow-overlay-gray-70: rgba(51, 51, 51, 0.7); | ||
|
|
||
| /* White Overlay */ | ||
| --ow-overlay-white-75: rgba(255, 255, 255, 0.75); |
Member
There was a problem hiding this comment.
What about using the term "light"?
Suggested change
| --ow-overlay-white-75: rgba(255, 255, 255, 0.75); | |
| --ow-overlay-light-75: rgba(255, 255, 255, 0.75); |
| --ow-color-login-bg: #f4f7f6; | ||
| --ow-color-scrollbar-track: #f1f1f1; | ||
|
|
||
| /* Overlays (Black with opacity) */ |
Member
There was a problem hiding this comment.
What about using the term "dark"?
Suggested change
| /* Overlays (Black with opacity) */ | |
| /* Overlays (Dark with opacity) */ |
| /* Success/Positive */ | ||
| --ow-color-success: #498b26; | ||
|
|
||
| /* Gray Scale Spectrum */ |
Member
There was a problem hiding this comment.
In theory these could change from gray/black to other colors, so what about using some other term, like foreground (abbreviated could be fg) or anything else that works well as common denominator?
pandafy
force-pushed
the
issues/487-theme-color-variables
branch
2 times, most recently
from
c9d7d3f to
20acaf6
Compare
pandafy
moved this from To do (general)
to Needs review
in OpenWISP Contributor's Board
pandafy
force-pushed
the
issues/487-theme-color-variables
branch
from
20acaf6 to
bd7a154
Compare
pandafy
force-pushed
the
issues/487-theme-color-variables
branch
from
bd7a154 to
5aa3818
Compare
pandafy
commented
Oct 16, 2025
| .auto-filter-choices .select2-results__option--highlighted { | ||
| background: #ffe5e5 !important; | ||
| color: #ba2121 !important; | ||
| color: var(--ow-selected-filter-option-text) !important; |
Member
Author
There was a problem hiding this comment.
This was using #ba2121 which is used for text in errors.
I have updated the style of the selected option in autocomplete filter to make it similar to other filter
Existing filters:
nemesifier
approved these changes
Oct 16, 2025
github-project-automation
bot
moved this from Needs review
to In progress
in OpenWISP Contributor's Board
github-project-automation
bot
moved this from In progress
to Done
in OpenWISP Contributor's Board
github-project-automation
bot
moved this from Ready for review/testing
to Done
in 25.09 Release
This was referenced Nov 17, 2025
Closed
This was referenced Nov 17, 2025
Open
4 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #487