Skip to content

Conversation

@pandafy
Copy link
Member

@pandafy pandafy commented Jul 18, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #482

Description of Changes

Updated docs to suggest overriding the template.

Updated docs to suggest overriding the template.

Closes #482
@pandafy pandafy moved this from To do (general) to Needs review in OpenWISP Contributor's Board Jul 18, 2025
@pandafy
Copy link
Member Author

pandafy commented Jul 18, 2025

I did a code search across OpenWISP to check where are we using the send_email method. We are not using any custom template anywhere in OpenWISP. Thus, I conclude that dropping support for OPENWISP_EMAIL_TEMPLATE will not have any negative effects.

@coveralls
Copy link

Coverage Status

coverage: 95.979% (-0.002%) from 95.981%
when pulling c1a8b78 on issues/482-remove-email-tempalte-setting
into cfbd63e on master.

@github-project-automation github-project-automation bot moved this from Needs review to In progress in OpenWISP Contributor's Board Jul 22, 2025
@nemesifier nemesifier merged commit 2f04ee3 into master Jul 22, 2025
22 checks passed
@nemesifier nemesifier deleted the issues/482-remove-email-tempalte-setting branch July 22, 2025 17:52
@github-project-automation github-project-automation bot moved this from In progress to Done in OpenWISP Contributor's Board Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[change] Remove OPENWISP_EMAIL_TEMPLATE setting and recommend overriding email_template.html

4 participants