[feature] Added retry mechanism to SeleniumTestMixin #464 #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To do (general)
in OpenWISP Contributor's Board
Member
Author
|
The test suite would fail if the test is flaky The test will be considered as pass, it it has success rate of 80% |
pandafy
force-pushed
the
issues/464-retry-selenium
branch
from
5ff8818 to
89d1aef
Compare
nemesifier
requested changes
May 22, 2025
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Please double check the docs text.
docs/developer/test-utilities.rst
Outdated
| methods that must be used across all OpenWISP modules based on Django to | ||
| enforce best practices and avoid flaky tests. | ||
|
|
||
| It also provides a retry mechanism for flaky tests, which executes the a |
Member
There was a problem hiding this comment.
Suggested change
| It also provides a retry mechanism for flaky tests, which executes the a | |
| It also provides a retry mechanism for *"flaky tests"*, which repeats any |
docs/developer/test-utilities.rst
Outdated
| This functionality can be configured using the following class attributes: | ||
|
|
||
| - ``retry_max``: Number of times to retry a test (default: ``5``). | ||
| - ``retry_delay``: Numbed of seconds to wait before retrying a test |
Member
There was a problem hiding this comment.
Suggested change
| - ``retry_delay``: Numbed of seconds to wait before retrying a test | |
| - ``retry_delay``: Number of seconds to wait before retrying a test |
docs/developer/test-utilities.rst
Outdated
|
|
||
| - ``retry_max``: Number of times to retry a test (default: ``5``). | ||
| - ``retry_delay``: Numbed of seconds to wait before retrying a test | ||
| (default: ``2``). |
Member
There was a problem hiding this comment.
Why do we need to wait to repeat tests? I'd set this to zero to avoid increasing build times.
Retry selenium tests if the tests fails on the first attempt. This prevents failng the CI build from flaky tests. Closes #464
pandafy
force-pushed
the
issues/464-retry-selenium
branch
from
89d1aef to
750df2f
Compare
nemesifier
approved these changes
May 23, 2025
github-project-automation
bot
moved this from In progress
to Done
in OpenWISP Contributor's Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #464
Description of Changes
Retry selenium tests if the tests fails on the first attempt. This prevents failng the CI build from flaky tests.