-
-
Notifications
You must be signed in to change notification settings - Fork 86
[change] Switched to prettier #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[change] Switched to prettier #425
Conversation
ceafd50 to
52bcd9f
Compare
nemesifier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I am testing.
We will need to update this page too:
https://openwisp.io/docs/dev/developer/contributing.html#javascript-code-conventions
We need to update the javascript code conventions section and add a new section for CSS.
This is the file that needs to be edited:
https://github.com/openwisp/openwisp-docs/blob/master/developer/contributing.rst
nemesifier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing the changes on OpenWISP Controller:
openwisp/openwisp-controller#969.
PR incoming! |
|
Hey @nemesifier |
I think in this case is ok to combine them since we use one tool for both. |
|
Ref: openwisp/openwisp-utils#425 --------- Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Checklist
Reference to Existing Issue
Closes #367