[qa] Document database queries in permission class tests #256 #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add assertNumQueries to the organization manager permission test to document the expected database queries triggered by permission and object-level access checks. These queries are intentional and required for security and multi-tenancy, and documenting them helps prevent confusion and accidental regressions. Fixes openwisp#256
Add assertNumQueries to the organization manager permission test to document the expected database queries triggered by permission and object-level access checks. These queries are intentional and required for security and multi-tenancy, and documenting them helps prevent confusion and accidental regressions. Fixes openwisp#256
Add assertNumQueries to the organization manager permission test to document the expected database queries triggered by permission and object-level access checks. These queries are intentional and required for security and multi-tenancy, and documenting them helps prevent confusion and accidental regressions. Fixes openwisp#256
Add assertNumQueries to the organization manager permission test to document the expected database queries triggered by permission and object-level access checks. These queries are intentional and required for security and multi-tenancy, and documenting them helps prevent confusion and accidental regressions. Fixes openwisp#256 Please enter the commit message for your changes. Lines starting
komaleswarreddy
force-pushed
the
tests/api-query-clarity
branch
from
6ac2a91 to
a88299e
Compare
nemesifier
reviewed
Dec 27, 2025
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
This PR looks spam. I don't understand what's the point of this.
| response = self.client.get(self.owner_url, **auth) | ||
| self.assertEqual(response.status_code, 403) | ||
|
|
||
| def test_operator_member(self): |
Member
There was a problem hiding this comment.
Why are you removing this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test clarity for Issue #256 by documenting the expected database queries triggered by the IsOrganizationManager permission check using assertNumQueries.
No application behavior is changed; this makes the security-related query cost explicit and helps prevent future confusion or accidental regressions.