[feature] Authorize view: allow receive called-station-id & calling-station-id, update Simultaneous-Use accordingly

[nemesifier]

The authorize API view currently only accepts username and password.

It should also accept Calling-Station-Id and Called-Station-Id, which is a common attribute in RADIUS requests (typically the MAC address of the client device).

The change should be backward compatible: if Calling-Station-Id/Called-Station-Id are not provided, the API should continue to work as it does today.

We shall also modify the Simultaneous-Use check to exclude the current Calling-Station-Id/Called-Station-Id for counting open sessions (if the same client is trying to reauthenticate from the same client to the same NAS, we should not fail).

We'll need to update the installers to enable this:

• [feature] Change freeradius rml_rest to send Calling-Station-Id in authorize ansible-openwisp2#548
• [feature] Change freeradius rml_rest to send Calling-Station-Id in authorize docker-openwisp#494

[jevinjojo]

Hi @nemesifier I'd like to work on this issue. I have gone through the description and just wanted to clarify, when we are updating the Simultaneous-Use check to exclude the current calling-station-id, should we exclude the session where it's the same username and Calling-Station-Id or any session with same Calling-Station-Id regardless of username?

[nemesifier]

Hi @nemesifier I'd like to work on this issue. I have gone through the description and just wanted to clarify, when we are updating the Simultaneous-Use check to exclude the current calling-station-id, should we exclude the session where it's the same username and Calling-Station-Id or any session with same Calling-Station-Id regardless of username?

Same username and calling-station-id.