[deps] Add support for Django 5.x and update channels #345
Conversation
github-project-automation
bot
moved this to To do (general)
in OpenWISP Contributor's Board
pandafy
force-pushed
the
deps-channels
branch
5 times, most recently
from
38289f5 to
3d247ca
Compare
requirements-test.txt
Outdated
| @@ -1,7 +1,4 @@ | |||
| openwisp-utils[qa,selenium] @ https://github.com/openwisp/openwisp-utils/tarball/1.2 | |||
| openwisp-utils[qa,selenium,channels, channels-test] @ https://github.com/openwisp/openwisp-utils/tarball/issues/388-channels | |||
There was a problem hiding this comment.
TODO: Update this once PR in openwisp-utils is merged.
pandafy
changed the title
pandafy
force-pushed
the
deps-channels
branch
6 times, most recently
from
be25baf to
78e42f7
Compare
| raise ImproperlyConfigured(f'No such Notification Choice {notification_type}') | ||
|
|
||
|
|
||
| def get_notification_choices(): |
There was a problem hiding this comment.
Are you sure this is necessary?
I don't see the django docs saying that passing a callable is necessary for choice fields. Am I missing something?
There was a problem hiding this comment.
I have added the comment in the code to explain the implementation details of Django
From the docs:
Passing a callable for choices can be particularly handy when, for example, the choices are:
the result of I/O-bound operations (which could potentially be cached), such as querying a table in the same or an external database, or accessing the choices from a static file.
a list that is mostly stable but could vary from time to time or from project to project. Examples in this category are using third-party apps that provide a well-known inventory of values, such as currencies, countries, languages, time zones, etc.
We fall in the second point. The NOTIFICATION_CHOICES changes when registering/unregistering notification types.
There was a problem hiding this comment.
Good, point I was forgetting this important detail for a moment.
| 'Operating System :: OS Independent', | ||
| 'Framework :: Django', | ||
| 'Programming Language :: Python :: 3.8', | ||
| 'Programming Language :: Python :: 3', |
There was a problem hiding this comment.
Can you update this consistently with the other modules please?
There was a problem hiding this comment.
We don't mention the Python version in any OpenWISP module. I checked the following
There was a problem hiding this comment.
Ok great, maybe the other modules I saw were libraries and we use more classifiers there.
- Dropped support for Python < 3.9 - Dropped support for Django < 4.2 Closes #340
| raise ImproperlyConfigured(f'No such Notification Choice {notification_type}') | ||
|
|
||
|
|
||
| def get_notification_choices(): |
There was a problem hiding this comment.
Good, point I was forgetting this important detail for a moment.
| 'Operating System :: OS Independent', | ||
| 'Framework :: Django', | ||
| 'Programming Language :: Python :: 3.8', | ||
| 'Programming Language :: Python :: 3', |
There was a problem hiding this comment.
Ok great, maybe the other modules I saw were libraries and we use more classifiers there.
github-project-automation
bot
moved this from To do (general)
to In progress
in OpenWISP Contributor's Board
github-project-automation
bot
moved this from In progress
to Done
in OpenWISP Contributor's Board
Checklist
Blockers
Closes #340