Skip to content

[tests] Synchronized custom command Selenium test - #1515

Open
nemesifier wants to merge 1 commit into
masterfrom
stabilize-command-selenium-test
Open

nemesifier wants to merge 1 commit into
masterfrom
stabilize-command-selenium-test

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

Reference to Existing Issue

N/A

Description of Changes

Synchronizes the custom-command Selenium test with the JSON editor state and persisted command before checking the dynamically rendered escaped value.

Screenshot

N/A

@nemesifier nemesifier added the testing Issue related to testing or CI label Oct 14, 2026
@nemesifier nemesifier self-assigned this Oct 14, 2026
@nemesifier nemesifier added the testing Issue related to testing or CI label Oct 14, 2026
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0b4bbc0c-34bb-44ba-9664-aef129ad7a98
📥 Commits

Reviewing files that changed from the base of the PR and between 0093a26 and 4881187.

📒 Files selected for processing: 1
  • openwisp_controller/connection/tests/test_selenium.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 11
  • GitHub Check: Python==3.12 | django~=5.2.0
  • GitHub Check: Python==3.13 | django~=5.2.0
  • GitHub Check: Python==3.11 | django~=5.1.0
  • GitHub Check: Python==3.11 | django~=5.2.0
  • GitHub Check: Python==3.12 | django~=5.1.0
  • GitHub Check: Python==3.10 | django~=5.2.0
  • GitHub Check: Python==3.10 | django~=5.1.0
  • GitHub Check: Python==3.13 | django~=5.1.0
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (python)
🧰 Additional context used
📚 Code guidelines: 1
AGENTS.md — auto-discovered
📓 Path-based instructions: 3
Ensure tests cover relevant success, error, boundary, and unusual input scenarios.

⚙️ CodeRabbit configuration file

Files:

  • openwisp_controller/connection/tests/test_selenium.py
Flag potential security vulnerabilities Flag obvious performance regressions, such as heavy loops, repeated I/O, or unoptimized queries Flag unused or redundant code Flag outdated or incorrect comments/docstrings Ensure new code handles err...

⚙️ CodeRabbit configuration file

Files:

  • openwisp_controller/connection/tests/test_selenium.py
Source excerpt: Before defining a test helper, including `_create_*`, `_get_*`, and `_test_*` methods, inspect the current test class's base classes, this module's `tests/__init__.py` and `tests/mixins.py`, `openwisp_users.tests.utils`, `op...

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • openwisp_controller/connection/tests/test_selenium.py
🔇 Additional comments: 1
openwisp_controller/connection/tests/test_selenium.py: 1

94-98: LGTM!

Also applies to: 100-105, 111-111

📝 Walkthrough

The command-input Selenium test now waits for the JSON editor to return the entered command and for a matching Command record to exist. The command-display visibility check now uses a five-second timeout.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: pandafy

Merge Risk: ⚪ Minimal · up to 48811

This change only adjusts Selenium test synchronization. No concrete issue remains, so it is ready to merge subject to normal checks.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Title check Passed The title uses the required [tests] prefix and clearly describes synchronization of the custom command Selenium test.
Description check Passed The description includes the checklist, change summary, issue reference, and screenshot sections. It marks applicable checklist items and uses N/A for non-applicable items, although the N/A entries do…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Ui Changes, Regression Test, Docs Passed The pull request changes only openwisp_controller/connection/tests/test_selenium.py. It adds synchronization and timeout handling to an existing Selenium regression test. It does not change applicat…
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.359%. first build — stabilize-command-selenium-test into master

@nemesifier

Copy link
Copy Markdown
Member Author

@dee077 #1507 introduced a very flaky test, this PR fixes it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review testing Issue related to testing or CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants