Skip to content

[ui] Highlight command status with colors #812 #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Srinath0916 wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −2
Open

[ui] Highlight command status with colors #812 #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da537d5
[ui] Highlight command status with colors #812
Srinath0916 Dec 1, 2025
3b49672
Merge branch 'master' into issues/812-ui-command-highlight
nemesifier Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions openwisp_controller/connection/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ class CommandInline(admin.StackedInline):
model = Command
verbose_name = _("Recent Commands")
verbose_name_plural = verbose_name
fields = ["status", "type", "input_data", "output_data", "created", "modified"]
readonly_fields = ["input_data", "output_data"]
fields = ["status_display", "type", "input_data", "output_data", "created", "modified"]
readonly_fields = ["status_display", "type", "input_data", "output_data", "created", "modified"]
formset = LimitedCommandResults

def get_queryset(self, request, select_related=True):
Expand Down Expand Up @@ -133,8 +133,18 @@ def output_data(self, obj):
)
return obj.output

def status_display(self, obj):
status_value = obj.status
css_class = f"command-status-{status_value}"
return format_html(
'<span class="{0}">{1}</span>',
css_class,
obj.get_status_display()
)

input_data.short_description = _("input")
output_data.short_description = _("output")
status_display.short_description = _("status")

def _get_conditional_queryset(self, request, obj, select_related=False):
return self.get_queryset(request, select_related=select_related).exists()
Expand Down
16 changes: 16 additions & 0 deletions openwisp_controller/connection/static/connection/css/command-inline.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,3 +231,19 @@ li.commands:not(.recent) {
width: 3.125em;
margin: 0.2em 0;
}

/* Command status highlighting */
.command-status-success {
color: #417927;
Copy link
Member

@nemesifier nemesifier Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we have variables for this? We recently started using CSS variables more. It may be a good idea to define these colors in openwisp-utils.

font-weight: bold;
}

.command-status-failed {
color: #ba2121;
font-weight: bold;
}

.command-status-in-progress {
color: #666;
font-weight: bold;
}
Loading