centralize channels==4.2 for django_loci #154
Conversation
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
@AviGawande are you still working on it? Did you see the CI build failures?
|
yes i re-runned the build tests but they are still failing |
devkapilbansal
left a comment
devkapilbansal
left a comment
There was a problem hiding this comment.
Hi @AviGawande
There are some formatting changes as well here. Why are they done? Kindly adhere to do the changes asked in the issue only.
| "http": get_asgi_application(), | ||
| } | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Why new lines at the end are removed?
| self.send_json(event['message']) | ||
|
|
||
| def disconnect(self, message=None): | ||
| def disconnect(self, close_code): |
There was a problem hiding this comment.
Why the default value is removed?
The build is failing because it can't find channels module now:-
|
| @@ -1,6 +1,5 @@ | |||
| # Does not supports Django 4.0.0 | |||
| django>=3.2.18,!=4.0.*,<4.3 | |||
| channels~=3.0.4 | |||
There was a problem hiding this comment.
Unless the changes in openwisp-qa are merged, we need to keep the channels package here.
There was a problem hiding this comment.
@devkapilbansal that's not correct, what we do is reference the patched openwisp-utils version, eg:
openwisp-utils @ https://github.com/AviGawande/openwisp-utils/tarball/upgrade-django-channels
See:
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Change the reference in requirements.txt and requirement-tests.txt to openwisp-utils:
openwisp-utils @ https://github.com/AviGawande/openwisp-utils/tarball/upgrade-django-channels
|
@AviGawande are you participating in our dev chat? |
|
@AviGawande Ping! |
5 participants
Checklist
Reference to Existing Issue
#388.