Check the file name for valid characters when using "Save As" in the problem editor. #2755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
problem-editor-save-as-check-filename
branch
from
7b95098 to
3778822
Compare
|
Eventually we need to eliminate the redirect in these cases when a save is aborted. To deal with that gracefully though, modifications in the CodeMirror window need to be handled better. |
|
Note that really, the redirect even in the case that a save does occur should be eliminated. That takes quite a bit of restructuring of the problem editor code though. |
…problem editor. This ensures that the given file name has the same valid characters that the file manager requires. Show the message "The text box now contains the source of the original problem. You can recover lost edits by using the Back button on your browser." any time that a save is not going to be done in the save_as handler, since it applies to any of those cases. Only set the `editFilePath` when a save really will occur. Finally, don't show the "File "[_1]" exists. File not saved. No changes have been made." message if no file name is given. This fixes issue openwebwork#2754.
drgrice1
force-pushed
the
problem-editor-save-as-check-filename
branch
from
3778822 to
47161e4
Compare
pstaabp
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the given file name has the same valid characters that the file manager requires.
Show the message "The text box now contains the source of the original problem. You can recover lost edits by using the Back button on your browser." any time that a save is not going to be done in the save_as handler, since it applies to any of those cases.
Only set the
editFilePathwhen a save really will occur.Finally, don't show the "File "[_1]" exists. File not saved. No changes have been made." message if no file name is given.
This fixes issue #2754.