Skip to content

XSS Fix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2013
Merged

XSS Fix #17

merged 9 commits into from
Jun 5, 2013

Conversation

goehle
Copy link
Member

@goehle goehle commented May 1, 2013

A fix for a potential XSS attack. Scrubs some potential badness before problem is even saved and also tries to escape more printed html.

@@ -29,7 +29,10 @@ =head1 DESCRIPTION

=cut

# this is equivalent to use strict, but can be used within the Safe compartment.
#sub _PGbasicmacros_init {use HTML::Entities::encode_entities;}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't belong here I think. It only needs to be included once in the file, not everytime the file
is called. It can go at the top of the file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure where to put packages where they would be usable within
PGAnswerMacro .... Feel free to move it
On Jun 2, 2013 10:41 PM, "Michael Gage" notifications@github.com wrote:

In macros/PGbasicmacros.pl:

@@ -29,7 +29,10 @@ =head1 DESCRIPTION

=cut

-# this is equivalent to use strict, but can be used within the Safe compartment.
+#sub _PGbasicmacros_init {use HTML::Entities::encode_entities;}

this doesn't belong here I think. It only needs to be included once in the
file, not everytime the file
is called. It can go at the top of the file.


Reply to this email directly or view it on GitHubhttps://github.com//pull/17/files#r4493451
.

whwheel pushed a commit to whwheel/pg that referenced this pull request Jun 3, 2013
mgage added a commit that referenced this pull request Jun 5, 2013
@mgage mgage merged commit d02dbd5 into openwebwork:release/2.6 Jun 5, 2013
drgrice1 pushed a commit to drgrice1/pg that referenced this pull request May 23, 2023
…ixes

Consolodate the category files into a single index.
pstaabp pushed a commit that referenced this pull request Apr 1, 2025
Fix typo in Matrix doc and add a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants