Fix bracket ends for graphtool intervals with the useBracketEnds setting.
#1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
graphtool-interval-bracket-ends-fix
branch
from
c197d1b to
e6db612
Compare
Alex-Jordan
approved these changes
Mar 24, 2025
…tting. In openwebwork#1157 I made it so that the `up`, `down`, and `drag` handlers for the defining points of graph objects are not added to static graph objects. However, in doing so for intervals I also made it so that the paired point association is not made. For most graph objects those associations are only needed when the handlers are added since they are used to prevent points from being moved in such a way to prevent degeneracy for the object. But for intervals that association is also used to determine which direction the brackets or parentheses should face when the `useBracketEnds` option is used. As such, now correct answer graphs always show those facing to the right even if they are on the right end.
drgrice1
force-pushed
the
graphtool-interval-bracket-ends-fix
branch
from
e6db612 to
e0578a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1157 I made it so that the
up,down, anddraghandlers for the defining points of graph objects are not added to static graph objects. However, in doing so for intervals I also made it so that the paired point association is not made. For most graph objects those associations are only needed when the handlers are added since they are used to prevent points from being moved in such a way to prevent degeneracy for the object. But for intervals that association is also used to determine which direction the brackets or parentheses should face when theuseBracketEndsoption is used. As such, now correct answer graphs always show those facing to the right even if they are on the right end.