Accelerated compositing fixes #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 19, 2012 20:04
We run into a weird recursive lock situation when we switch rendering backends, eg. opengl to raster in webkit. Fixed by making this lock recursive.
QGraphicsView contians an invisible QFrame and repeint requests will cause this frame to try to flush its non-existant contents to its non-existant backingsurface. This ends up causing a glFlush leading to always showing the wrong framebuffer since we flip once for the actual QGLWidget painting and then again for the frame
We don't use this proprietary class anymore since it gave us bad performance. Instead we use QRasterPixmapData or QGLPixmapData where appropriate.
our QPAs are littered with useless debug messages, cleaning up some.
ghost
assigned
rogerjstringer
added a commit
that referenced
this pull request
Jul 20, 2012
NAYA-121: Accelerated compositing fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reworked the changes into individual changesets for each issue and added more descriptive commit messages. fixed a typo in the previous pull request.