Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ledger): handle REQNACK response for write request #967

Merged
merged 1 commit into from
Jul 28, 2022
Merged

feat(ledger): handle REQNACK response for write request #967

merged 1 commit into from
Jul 28, 2022

Conversation

jakubkoci
Copy link
Contributor

I'm not sure if the check for REQNACK response was omitted in the write request method on purpose, but registerSchema is throwing a confusing error.

Previously:

TypeError: Cannot read property 'txnMetadata' of undefined

After the update:

Ledger 'pool-localhost' rejected write transaction request: client request invalid: could not authenticate, verkey for 9gFCquotxSS7ctKG1GJatU cannot be found

@jakubkoci
feat(ledger): handle REQNACK response for write request
1e82cbe 
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
@jakubkoci jakubkoci requested a review from a team as a code owner July 28, 2022 07:46
@berendsliedrecht
Copy link
Contributor

I think it was just forgotten to do when it was added in this PR: #626

I don't see a reason why this would be omitted.

@jakubkoci jakubkoci merged commit 6468a93 into openwallet-foundation:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubkoci @berendsliedrecht