feat: present proof v2 #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
…r/aries-framework-javascript into hyperledger-feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
…r/aries-framework-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Feat/present proof v2
…r/aries-framework-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Feat/present proof v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
…d to id Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
…work-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
TimoGlastra
reviewed
May 9, 2022
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
…work-javascript into feat/present-proof-v2
…atkar/aries-framework-javascript into feat/present-proof-v2
…work-javascript into feat/present-proof-v2
…work-javascript into feat/present-proof-v2
…work-javascript into feat/present-proof-v2
…work-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
…work-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
…work-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
TimoGlastra
reviewed
May 19, 2022
There was a problem hiding this comment.
I left some additional comments, but I think we're almost there. What I'd like to propose is to merge this PR into the feat/ppv2 branch. The additional comments can be resolved in PRs to that branch as it's not manageable anymore to keep working from this PR.
@NB-PrasadKatkar what do you think?
packages/core/src/modules/proofs/protocol/v2/handlers/V2ProposePresentationHandler.ts
Show resolved
Hide resolved
packages/core/src/modules/proofs/protocol/v2/handlers/V2RequestPresentationHandler.ts
Show resolved
Hide resolved
packages/core/src/modules/proofs/protocol/v2/messages/V2PresentationAckMessage.ts
Show resolved
Hide resolved
packages/core/src/modules/proofs/protocol/v2/messages/V2RequestPresentationMessage.ts
Show resolved
Hide resolved
packages/core/src/modules/proofs/repository/PresentationExchangeRecord.ts
Show resolved
Hide resolved
TimoGlastra
dismissed stale reviews from berendsliedrecht, karimStekelenburg, and themself
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on Present Proof V2 to work with Indy credentials