feat: added ability to refresh the pool manually

[wadeking98]

Previously AFJ wouldn't call refresh on genesis files, this meant that the pool could be out of date and contain dead nodes. This change adds a function to the pool service that allows an afj user to manually refresh the pool as needed. Example:

const poolService = newAgent.dependencyManager.resolve(IndyVdrPoolService)
await poolService.refreshPoolConnections()

all the pools are refreshed asynchronously so it doesn't take more than 1 - 2 seconds on BC Wallet.

Note: I tried returning the transactions too so that we could cache them, however when I was playing around with the yarn patch I made, whenever I called this._pool.transactions in the IndyCdrPool.js file I would get a JSON parse error. I was unclear what was causing the error, it seems to be coming from the indy-vdr-shared library

[codecov-commenter]

Codecov Report

Merging #1623 (68bbc1a) into main (ec3182d) will decrease coverage by 0.03%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
- Coverage   85.67%   85.65%   -0.03%     
==========================================
  Files         959      959              
  Lines       23082    23095      +13     
  Branches     4049     4050       +1     
==========================================
+ Hits        19775    19781       +6     
- Misses       3123     3129       +6     
- Partials      184      185       +1     

Files	Coverage Δ
packages/indy-vdr/src/index.ts	100.00% <100.00%> (ø)
packages/indy-vdr/src/IndyVdrApi.ts	87.50% <0.00%> (-12.50%)	⬇️
packages/indy-vdr/src/pool/IndyVdrPoolService.ts	80.48% <0.00%> (-4.13%)	⬇️
packages/indy-vdr/src/pool/IndyVdrPool.ts	80.00% <0.00%> (-6.67%)	⬇️

... and 3 files with indirect coverage changes

[TimoGlastra]

Thanks @wadeking98! We can probably expose this method as well on the IndyVdrApi, so you can acces it on agent.modules.indyVdr.xxx

Re the parse error, the transactios is not a valid json array/object. As each line is a separate json object, but it's not constructed as an array. Maybe we do some incorrect parsing in the indy vdr lib..

[TimoGlastra]

It seems the react native wrappers calls json.parse in poolGetTransactions, while the Node.JS wrapper doesn't: https://github.com/hyperledger/indy-vdr/blob/main/wrappers/javascript/indy-vdr-react-native/src/ReactNativeIndyVdr.ts

@berendsliedrecht could you make a quick fix for this in Indy VDR?

[berendsliedrecht]

It seems the react native wrappers calls json.parse in poolGetTransactions, while the Node.JS wrapper doesn't: https://github.com/hyperledger/indy-vdr/blob/main/wrappers/javascript/indy-vdr-react-native/src/ReactNativeIndyVdr.ts

@berendsliedrecht could you make a quick fix for this in Indy VDR?

hyperledger/indy-vdr#234

[TimoGlastra]

This is not a promise right? So then allSettled is not needed I think?

[wadeking98]

pool.transactions returns a promise

[genaris]

Thanks @wadeking98! Do you think it could be useful to add some JSDoc comments in the new methods for IndyVdrApi? They seem to be self-explanatory (and do not get any input parameter but probably can help others to notice about their use cases (e.g. the performance issue that raised this PR).

[wadeking98]

@genaris @TimoGlastra I don't have permissions to merge this so one of you will have to do it when you're ready

[genaris]

@genaris @TimoGlastra I don't have permissions to merge this so one of you will have to do it when you're ready

Sure, can you fix the Validate error? A yarn prettier -w should do the trick I think