fix: DidCommV2 - avoid breaking changes #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artemkaaas
changed the title
…ping message Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
…Unified MessageSender Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
…ility Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Artemkaaas
force-pushed
the
feat/didcomm-v2-breacking-changes
branch
from
47c4475
to
2666edf
Compare
genaris
approved these changes
Aug 4, 2023
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
genaris
merged commit afeb38e
into
openwallet-foundation:feat/didcomm-v2
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to avoid breaking changes compared to the main branches.
AgentMessageclass which actually isDidCommV1Message.AgentBaseMessageis a common interface for V1/V2 - used internallyAttachmentfor DidCommV1 message attachmentsSigningProviderDifferences with the
mainoutOfBandInvitationfield of the OutOfBand record is optionalv2OutOfBandInvitationTransportSession-keysandinboundMessagerefers to different types but it should not break implementations.TransportSession