Python and Perl scripts: Print warnings, errors and usage to stderr #5924
+69
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solardiz
approved these changes
Dec 20, 2025
Member
solardiz
left a comment
solardiz
left a comment
There was a problem hiding this comment.
The changes look good to me, but seem incomplete. At least this is still missing the newlines:
fvde2john.py: sys.stderr.write("cryptography is missing, run 'pip install --user cryptography' to install it!")
fvde2john.py: sys.stderr.write("pytsk3 is missing, run 'pip install --user pytsk3' to install it!")
fvde2john.py: sys.stderr.write("Error reading out of bounds of file, exiting.")
fvde2john.py: sys.stderr.write(f"[!] Invalid sector size {sector_size} (not 512 or 4096 bytes). Exiting.")
fvde2john.py: sys.stderr.write("[!] No CoreStorage volumes found, exiting.")
Member
Author
|
Oh, I fixed those but dropped/postponed it because of #5895. I see now I even mentioned it in #5900 (comment). I'll fix them and add here. I'll also retry some grep-fu. |
Also print usage to stderr, which isn't always the norm but in this case we're normally running redirected to file and the usage blob may be caused by options/syntax problems.
solardiz
approved these changes
Dec 21, 2025
Member
Author
|
Will add yet some to this, I found more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add missing newlines to some python calls to
sys.*.write.Usage to stderr isn't always the norm but in this case we're normally running redirected to file and the usage blob may be caused by options/syntax problems.