-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add krb5tgs-sha1 formats: Attacks TGS-REP for etypes 17 and 18 #5314
Conversation
Also known as aes-cts-hmac-sha1-96. The existing krb5tgs formats are for etype 23 (rc4-hmac) and too different from 17/18 that it would be relevant to add this functionality to them. Also add "cost" notion of etype for a few existing formats, and changed their benchmark to etype 17 instead of some unknown mix of etypes. Closes openwall#2809
See also #5315 |
This inflates speed for some formats and deflates it for others - but the benchmark outputs a cost line that clarifies why. Before:
After:
Also:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I skimmed and didn't notice anything obviously wrong/worse compared to the kind of code we had for this kind of formats before. There's much detail I can't fully review without diving into the specifics of these new formats. I don't know whether FMT_DYNA_SALT | FMT_HUGE_INPUT
is right. Also, I guess we'll need to rerun the formats fuzzer sometime soon as we've got a few formats added since Aleksey's fuzzing.
BTW we now don't get to see the effect of the |
Yes, perhaps. Or maybe we want to have separate format structs per etype, so that our all-formats benchmark includes all of these results individually - of course, then we'd want to do similar to other formats where we combined different-speed sub-formats into one. |
I'll leave such changes to #5315 |
Also known as aes-cts-hmac-sha1-96. The existing krb5tgs formats are for etype 23 (rc4-hmac) and too different from 17/18 that it would be relevant to add this functionality to them.
Also add "cost" notion of etype for a few existing formats, and changed their benchmark to etype 17 instead of some unknown mix of etypes.
Closes #2809