New variance parameter: tension #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # training/acoustic_task.py
# Conflicts: # utils/binarizer_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tension, a new variance parameter.
Briefly, tension is related to the ratio of the base harmonic to the full harmonics. Low ratio (meaning other harmonics are powerful compared to the base harmonic) stands for high tension.
Tension is normally expected to be a better successor to energy. It controls the strength of singing voice much more effectively, and pushes the expressiveness to a new level.
Other changes in this PR:
DecomposedWaveformclass to take apart aperiodict part, harmonic part and each level of harmonics from a waveform.hparamsfrom all pitch extraction APIs to make them more reusable.