Skip to content

fix: constrain internal_flag to constant in VerifierPvsAir - #3123

Merged
stephenh-axiom-xyz merged 3 commits into
develop-v2.0-fvfrom
fix/constant-internal-flag
Aug 19, 2026
Merged

fix: constrain internal_flag to constant in VerifierPvsAir#3123
stephenh-axiom-xyz merged 3 commits into
develop-v2.0-fvfrom
fix/constant-internal-flag

Conversation

@stephenh-axiom-xyz

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

This comment has been minimized.

Comment thread Cargo.lock
@@ -1867,7 +1867,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "117725a109d387c937a1533ce01b450cbde6b88abceea8473c4d7a85853cda3c"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes intentional?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, was failing audit

@github-actions

Copy link
Copy Markdown
Contributor
group app.proof_time_ms app.cycles leaf.proof_time_ms
fibonacci 1,549 12,000,265 357
keccak 9,220 18,655,329 1,511
sha2_bench 4,895 14,793,960 578
regex 669 4,137,067 214
ecrecover 427 123,583 188
pairing 570 1,745,757 192
kitchen_sink 2,178 2,579,903 471

Note: cells_used metrics omitted because CUDA tracegen does not expose unpadded trace heights.

Commit: 6c3ec0d

Benchmark Workflow

@github-actions

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@stephenh-axiom-xyz
stephenh-axiom-xyz merged commit 790c184 into develop-v2.0-fv Aug 19, 2026
67 checks passed
@stephenh-axiom-xyz
stephenh-axiom-xyz deleted the fix/constant-internal-flag branch August 19, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants