feat(new-execution): AdapterTraceStep trait and rv32 ALU refactor
#1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
force-pushed
the
feat/rest-of-rv32im-tracegen
branch
from
cedfafb to
f9d0912
Compare
jonathanpwang
changed the title
AdapterTraceStep trait and rv32 ALU refactor
Golovanov399
approved these changes
Apr 21, 2025
| let data: [[F; NUM_LIMBS]; 2] = reads.into(); | ||
| let b = data[0].map(|x| x.as_canonical_u32()); | ||
| let c = data[1].map(|y| y.as_canonical_u32()); | ||
| let b = data[0].map(|x| x.as_canonical_u32() as u8); |
There was a problem hiding this comment.
Do we want a checked conversion here just in case?
There was a problem hiding this comment.
this one is temporary - going to switch to trying to avoid conversions at all later
jonathanpwang
added a commit
that referenced
this pull request
May 2, 2025
…1589) Co-authored-by: Alexander Golovanov <Golovanov12345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.