feat(new-execution): TracingMemory and removal of records/logs
#1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config.max_constraint_degree as u32 - 1, | ||
| ), | ||
| offline_memory, | ||
| memory_controller.offline_memory.clone(), |
There was a problem hiding this comment.
nit: or just .offline_memory()?
| debug_assert!(block_size.is_power_of_two()); | ||
| debug_assert_eq!(block_size % align, 0); | ||
| debug_assert_ne!(addr_space, 0); | ||
| debug_assert_eq!(align as u32, self.min_block_size[addr_space as usize]); |
There was a problem hiding this comment.
Why do we pass align then when we could just get it from self.min_block_size?
There was a problem hiding this comment.
I don't want to do the memory lookup to self.min_block_size (maybe it stays in cache?) when it should be more like a constant
jonathanpwang
added a commit
that referenced
this pull request
May 2, 2025
- deleting `Vm{Adapter,Core}Chip` traits
- no more records, directly use trace buffer
- jal_lui chip is a demonstration of the new changes with working unit
tests
- changed unit tester
- [x] need to add some dummy volatile memory to the tester to balance
based on touched addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleting
Vm{Adapter,Core}Chiptraitsno more records, directly use trace buffer
jal_lui chip is a demonstration of the new changes with working unit tests
changed unit tester
need to add some dummy volatile memory to the tester to balance based on touched addresses