Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .cache/torch/hub to local for openvoice #2359

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

sbalandi
Copy link
Contributor

@sbalandi sbalandi commented Sep 3, 2024

CVS-149572

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sbalandi sbalandi marked this pull request as ready for review September 3, 2024 15:53
@sbalandi
Copy link
Contributor Author

sbalandi commented Sep 3, 2024

previous fix PR#2300 based on issue myshell-ai/OpenVoice#57 and solution / https://github.com/myshell-ai/OpenVoice/blob/main/docs/QA.md#issues-with-installation

here TORCH_HOME is moved to local path, it should be absolute because the path is used to creation simulink inside the se_extractor.get_se

@eaidova
Copy link
Collaborator

eaidova commented Sep 4, 2024

@sbalandi can you please also setting cache dir tgenerally in validation script too like we do for hf hub https://github.com/openvinotoolkit/openvino_notebooks/blob/latest/.ci/validate_notebooks.py#L203-L204

I think it can provide better cache controlling and be beneficial for other notebooks too (e.g. automatic cleaning disk space after notebook run)

@eaidova eaidova merged commit 40d8b01 into openvinotoolkit:latest Sep 4, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants