[wip] NPUW: Handle closures just once for single-shot functions #27132
+12
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: NPU
dmatveev
changed the title
| // So - closure update is NOT required, OR the function is SINGLE - | ||
| // just handle it's closure here and don't do it in runtime | ||
| if (!m_closure_update_required || func_desc.forced_to_fcall) { | ||
| unpack_closure(i, m_subrequests[real_idx]); |
There was a problem hiding this comment.
So it'll be called in CWAI case or in forced case. Why do we change set_tensor to unpack_closure for CWAI case?
| @@ -718,7 +707,7 @@ void ov::npuw::JustInferRequest::function_prologue(std::size_t idx) { | |||
| // 2. Unpack the function closure -- right here, if pipelining if not enabled. | |||
| // If it is enabled, the flow is a little bit different - see run_subrequest_for_success() | |||
| // for details. | |||
| if (!is_pipelined(idx)) { | |||
| if (!is_pipelined(idx) && m_closure_update_required && !func_desc.forced_to_fcall) { | |||
There was a problem hiding this comment.
Wait... is_pipelined checks && !desc.forced_to_fcall - how does it work with && !func_desc.forced_to_fcall?
| @@ -765,7 +754,7 @@ void ov::npuw::JustInferRequest::unpack_closure(std::size_t idx, RqPtr request) | |||
| if (closure.get_element_type() != clparam->get_element_type()) { | |||
| // Remember where the unpack is required | |||
| closure_unpack_required.push_back(cidx); | |||
| } else if (m_npuw_model->m_update_required) { | |||
There was a problem hiding this comment.
Could you explain this?
Before we had
- CWAI (forced to fcall) - set_tensor
- Ordinary rep block, not forced - copy
- Single block, forced - unpack
Now
- CWAI (forced to fcall) - unpack
- Ordinary rep block, not forced - unpack
- Single block, forced - copy
Right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: