Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Update OpenVINO build instruction (Android system) #24815

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[DOCS] Update OpenVINO build instruction (Android system) #24815

merged 1 commit into from
Jun 10, 2024

Conversation

allnes
Copy link
Contributor

@allnes allnes commented Jun 3, 2024

No description provided.

@allnes allnes added category: CPU OpenVINO CPU plugin platform: android OpenVINO on Android platform: arm OpenVINO on ARM / ARM64 labels Jun 3, 2024
@github-actions github-actions bot added category: docs OpenVINO documentation and removed category: CPU OpenVINO CPU plugin labels Jun 3, 2024
@allnes allnes added the category: CPU OpenVINO CPU plugin label Jun 5, 2024
@github-actions github-actions bot removed the category: CPU OpenVINO CPU plugin label Jun 5, 2024
@allnes allnes requested a review from tsavina June 6, 2024 13:41
@allnes allnes marked this pull request as ready for review June 6, 2024 13:41
@allnes allnes requested a review from a team as a code owner June 6, 2024 13:41
@allnes allnes changed the title [ARM CPU] Add build instruction of OpenVINO on Android ARM system [ARM CPU] Update build instruction of OpenVINO on Android system Jun 6, 2024
@allnes allnes changed the title [ARM CPU] Update build instruction of OpenVINO on Android system [ARM CPU] Update OpenVINO build instruction (Android system) Jun 6, 2024
@allnes allnes changed the title [ARM CPU] Update OpenVINO build instruction (Android system) Update OpenVINO build instruction (Android system) Jun 6, 2024
@allnes allnes removed the platform: arm OpenVINO on ARM / ARM64 label Jun 6, 2024
@allnes allnes changed the title Update OpenVINO build instruction (Android system) [DOCS] Update OpenVINO build instruction (Android system) Jun 6, 2024
@allnes allnes requested a review from ilya-lavrenov June 6, 2024 18:48
ilya-lavrenov
ilya-lavrenov reviewed Jun 7, 2024
View reviewed changes
docs/dev/build_android.md Outdated
-DANDROID_PLATFORM=$CURRENT_ANDROID_PLATFORM \
-DANDROID_STL=$CURRENT_ANDROID_STL \
-DTBB_DIR=$OPV_HOME_DIR/one-tbb-install \
-DTBBROOT=$OPV_HOME_DIR/one-tbb-install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can keep only TBB_DIR to point to folder with cmake files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov corrected

docs/dev/build_android.md Outdated Show resolved Hide resolved
docs/dev/build_android.md Outdated
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$OPV_HOME_DIR/openvino-install \
-DENABLE_SAMPLES=ON \
-DENABLE_TESTS=ON \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to build tests? how they can be useful for users (not developers)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov corrected

docs/dev/build_android.md Outdated
-B $OPV_HOME_DIR/one-tbb-build \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$OPV_HOME_DIR/one-tbb-install \
-DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_PATH/build/cmake/android.toolchain.cmake \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set CMAKE_TOOLCHAIN_FILE globally? so, it can be used by both TBB and OpenVINO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov corrected

docs/dev/build_android.md Outdated
-B $OPV_HOME_DIR/openvino-build \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$OPV_HOME_DIR/openvino-install \
-DENABLE_SAMPLES=ON \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ON default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov corrected

docs/dev/build_android.md Outdated
### Use ADB tool to run example model and check library
```bash
# Copy OpenVINO™ libraries and executables to android device
$ANDROID_TOOLS_PATH/adb push --sync $OPV_HOME_DIR/openvino/bin/aarch64/Release/* /data/local/tmp/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not from installation folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov corrected

ilya-lavrenov
ilya-lavrenov reviewed Jun 7, 2024
View reviewed changes
docs/dev/build_android.md Outdated
mv android-ndk-r20 android-ndk
mkdir openvino-android
export OPV_HOME_DIR=${PWD}/openvino-android
export CURRENT_ANDROID_ABI=arm64-v8a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we highlight that x86_64 can be used as well? E.g. that value to set depending on underlying HW

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov updated, but below is also a description of which ABI can be used

tsavina
tsavina reviewed Jun 7, 2024
View reviewed changes
docs/dev/build_android.md Outdated Show resolved Hide resolved
docs/dev/build_android.md Outdated Show resolved Hide resolved
docs/dev/build_android.md Outdated Show resolved Hide resolved
docs/dev/build_android.md Outdated Show resolved Hide resolved
docs/dev/build_android.md Outdated Show resolved Hide resolved
docs/dev/build_android.md Outdated Show resolved Hide resolved
docs/dev/build_android.md Outdated Show resolved Hide resolved
@allnes allnes force-pushed the an/android_instruction branch 3 times, most recently from 4723768 to c82ef06 Compare June 9, 2024 01:17
@allnes allnes force-pushed the an/android_instruction branch from c82ef06 to 6451f62 Compare June 9, 2024 01:28
@allnes allnes requested review from ilya-lavrenov and tsavina June 9, 2024 09:25
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Jun 10, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2024.3 milestone Jun 10, 2024
Merged via the queue into openvinotoolkit:master with commit a9cceb3 Jun 10, 2024
83 checks passed
alexandruenache1111 pushed a commit to alexandruenache1111/openvino that referenced this pull request Jun 13, 2024
@allnes @alexandruenache1111
[DOCS] Update OpenVINO build instruction (Android system) (openvinoto…
0370b42 
…olkit#24815)
allnes added a commit to allnes/openvino that referenced this pull request Jun 27, 2024
@allnes
[DOCS] Update OpenVINO build instruction (Android system) (openvinoto…
6a3b576 
…olkit#24815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@tsavina tsavina Awaiting requested review from tsavina

Assignees
No one assigned
Labels
category: docs OpenVINO documentation platform: android OpenVINO on Android
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.
3 participants
@allnes @ilya-lavrenov @tsavina